Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serialize nillable copmlex types as nil #14320

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Dec 20, 2024

Description

Serialize nillable complex types as nil if the value is set to null.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes backend labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (276f5ef) to head (5c1a432).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14320   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files        1837     1837           
  Lines       23856    23856           
  Branches     2754     2754           
=======================================
  Hits        22798    22798           
  Misses        801      801           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirkoSekulic mirkoSekulic added the skip-manual-testing PRs that do not need to be tested manually label Dec 20, 2024
@mirkoSekulic mirkoSekulic removed the skip-releasenotes Issues that do not make sense to list in our release notes label Dec 20, 2024
@mirkoSekulic mirkoSekulic merged commit 6714508 into main Dec 20, 2024
19 checks passed
@mirkoSekulic mirkoSekulic deleted the feature/complex-nil branch December 20, 2024 08:00
@mirkoSekulic mirkoSekulic self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. backend quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants