Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure stream is closed after being read from app-dev's GetDefinitions method #14334

Merged
merged 7 commits into from
Jan 3, 2025
Merged

fix: ensure stream is closed after being read from app-dev's GetDefinitions method #14334

merged 7 commits into from
Jan 3, 2025

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Dec 27, 2024 •
edited by TomasEng
Loading

Description

Ensure stream is closed after being read from app-dev's GetDefinitions method

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Dec 27, 2024
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend labels Dec 27, 2024
@standeren standeren linked an issue Dec 27, 2024 that may be closed by this pull request
Errors occasionally occur when updating the process file #14229
Closed
@standeren standeren added team/studio-domain1 skip-releasenotes Issues that do not make sense to list in our release notes skip-documentation Issues where updating documentation is not relevant labels Dec 27, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (20b4540) to head (6cc5ead).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14334   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files        1860     1860           
  Lines       24104    24106    +2     
  Branches     2783     2783           
=======================================
+ Hits        23029    23031    +2     
  Misses        817      817           
  Partials      258      258

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren requested a review from mirkoSekulic January 2, 2025 11:52
@ErlingHauan ErlingHauan self-assigned this Jan 3, 2025
ErlingHauan
ErlingHauan approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing: Fixes the linked issue 👍

@ErlingHauan ErlingHauan merged commit a712b7d into main Jan 3, 2025
17 checks passed
@ErlingHauan ErlingHauan deleted the fix-500-from-put-bpmn branch January 3, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErlingHauan ErlingHauan ErlingHauan approved these changes

@mirkoSekulic mirkoSekulic mirkoSekulic approved these changes

Assignees

@ErlingHauan ErlingHauan

Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. backend frontend skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Team Studio
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors occasionally occur when updating the process file
3 participants
@standeren @mirkoSekulic @ErlingHauan