Fixed openByDefault to use filter

[bjosttveit]

Description

Open by default "first" and "last" is also broken by filters. In order to fix this the saga doing the open by default also needs to compute the filteredIndexList like the GroupContainer does. This function has been moved out of the component so that both the saga and the GroupContainer can use the same implementation.

I tried to make a general function, but the existing implementation did not make complete sense to me. It did not seem like it would work as documented, but by trying to reimplement it differently it broke some cypress tests.
The issues related to filters are documented here: #339 (comment)

Related Issue(s)

• openByDefault = "first" does not work with filters #569

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

52.4% Coverage
0.0% Duplication

[bjosttveit]

For future reference, here is the "more correct" implementation of getRepeatingGroupFilteredIndices:

app-frontend-react/src/altinn-app-frontend/src/utils/formLayout.ts

Lines 561 to 608 in 2b4ad09

	/**
	* Returns a list of remaining repeating group element indices after all filters are applied. Returns undefined if no filters are present.
	* @param repeatingGroupIndex IRepeatingGroup.index for the repeating group.
	* @param formData IFormData
	* @param filter IGroupEditProperties.filter or undefined.
	* @returns a list of indices for repeating group elements after applying filters, or null if no filters are provided.
	*/
	export function getRepeatingGroupFilteredIndices(
	repeatingGroupIndex: number,
	formData: IFormData,
	filter?: IGroupFilter[],
	): number[] | null {
	if (filter && filter.length > 0) {
	let filteredIndicies = Array.from(Array(repeatingGroupIndex + 1).keys());
	filter.forEach((rule) => {
	const formDataKeys: string[] = Object.keys(formData);
	if (formDataKeys && formDataKeys.length > 0) {
	const matchingSet = new Set<number>();
	formDataKeys
	.filter((key) => {
	const keyWithoutIndex = key.replaceAll(/\[\d*\]/g, '');
	return keyWithoutIndex === rule.key && formData[key] === rule.value;
	})
	.forEach((key) => {
	const match = key.match(/\[(\d*)\]/g);
	const currentIndex = match[match.length - 1];
	const matchingIndex = parseInt(
	currentIndex.substring(1, currentIndex.indexOf(']')),
	10,
	);
	matchingSet.add(matchingIndex);
	});
	filteredIndicies = filteredIndicies.filter((index) =>
	matchingSet.has(index),
	);
	return Array.from(matchingSet);
	}
	});
	return filteredIndicies;
	}
	return null;
	}