Skip to content
Code test and analysis

Correspondence client #2692

Sign in to view logs

Correspondence client

Correspondence client #2692

Triggered via pull request November 13, 2024 08:48
@danielskovlidanielskovli
synchronize #897
correspondence-client
Status Success
Total duration 9m 31s
Artifacts –

test-and-analyze.yml

on: pull_request
Static code analysis
8m 33s
Static code analysis
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Static code analysis: src/Altinn.App.Core/Configuration/PlatformSettings.cs#L52
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Static code analysis: src/Altinn.App.Core/Features/Correspondence/Models/CorrespondenceRequest.cs#L202
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Static code analysis: src/Altinn.App.Core/Features/Correspondence/Models/SendCorrespondencePayload.cs#L39
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Static code analysis: src/Altinn.App.Core/Features/Correspondence/Models/SendCorrespondencePayload.cs#L58
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Static code analysis: src/Altinn.App.Core/Models/UserAction/UserActionContext.cs#L53
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Static code analysis: src/Altinn.App.Core/Models/UserAction/UserActionContext.cs#L43
Do not forget to remove this deprecated code someday. (https://rules.sonarsource.com/csharp/RSPEC-1133)
Static code analysis: src/Altinn.App.Core/Features/Correspondence/Builder/CorrespondenceRequestBuilder.cs#L231
Rename parameter 'attachment' to 'builder' to match the interface declaration. (https://rules.sonarsource.com/csharp/RSPEC-927)
Static code analysis: src/Altinn.App.Core/Features/Correspondence/Models/CorrespondenceRequest.cs#L148
Remove the unnecessary Boolean literal(s). (https://rules.sonarsource.com/csharp/RSPEC-1125)
Static code analysis: src/Altinn.App.Core/Features/Correspondence/CorrespondenceClient.cs#L85
Either log this exception and handle it, or rethrow it with some contextual information. (https://rules.sonarsource.com/csharp/RSPEC-2139)
Static code analysis: src/Altinn.App.Core/Features/Correspondence/CorrespondenceClient.cs#L147
Logging arguments should be passed to the correct parameter. (https://rules.sonarsource.com/csharp/RSPEC-6668)