Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AppLogo): extend settings for appowner logo in applactionMetadata #297

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

mikaelrss
Copy link
Contributor

@mikaelrss mikaelrss commented Aug 28, 2023

Description

Changes the settings for showing app organisation logo. App developers can now decide from which source the logo should be fetched, altinn-orgs.json or resource files. App developers can also explicitly set whether or not appOwner should be displayed alongside the logo in the header. This is so that organisations with organisation name in the logo should not get the organisation name displayed multiple times.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mikaelrss mikaelrss force-pushed the feat/138-appowner-logo-settings branch from f391479 to 550e290 Compare August 28, 2023 06:59
@mikaelrss mikaelrss requested a review from tjololo August 28, 2023 08:09
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make it clear what is shown/hidden by this configuration

src/Altinn.App.Core/Models/Logo.cs Outdated Show resolved Hide resolved
@mikaelrss mikaelrss requested a review from tjololo August 29, 2023 06:24
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mikaelrss mikaelrss requested a review from tjololo August 29, 2023 10:21
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@tjololo tjololo added the feature Label Pull requests with new features. Used when generation releasenotes label Aug 29, 2023
@mikaelrss mikaelrss merged commit 8e355e3 into main Aug 29, 2023
10 checks passed
@mikaelrss mikaelrss deleted the feat/138-appowner-logo-settings branch August 29, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants