Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more warnings #331

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix more warnings #331

merged 1 commit into from
Nov 14, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Oct 26, 2023

  • ImplicitUsings is enabled with "enabled" not "true"
  • Fix nullability warnings
  • use FluentAssertions in a test to avoid nullability warning.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

@ivarne
Fix more warnings
245c369 
* ImplicitUsings is enabled with "enabled" not "true"
* Fix nullability warnings
* use FluentAssertions in a test to avoid nullability warning.
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 1 Code Smell

60.0% 60.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ivarne ivarne requested a review from RonnyB71 November 2, 2023 07:14
@ivarne ivarne requested a review from tjololo November 13, 2023 09:21
@ivarne ivarne merged commit c141a3f into v8 Nov 14, 2023
9 of 10 checks passed
@ivarne ivarne deleted the ivarne/more-warnings branch November 14, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

@RonnyB71 RonnyB71 Awaiting requested review from RonnyB71

Assignees
No one assigned
Labels
None yet
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivarne @tjololo