Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app-lib-dotnet to multi-target dotnet6 and dotnet8 with c# 12 #342

Closed
wants to merge 1 commit into from

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 14, 2023

Also include code that allows for unchecked use of required attributes in net6.0 (so we can start using required properties without dropping support for net6.0)

This is an alternative to #340 that preserves support for apps that use net6.0. I think this adds much more complexity to app management than what it is worth.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Also include code that allows for unchecked use of `required` attributes in net6.0
@ivarne ivarne added this to the 8.0.0 milestone Nov 14, 2023
@ivarne ivarne requested a review from tjololo November 14, 2023 21:19
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ivarne ivarne closed this Nov 15, 2023
@ivarne ivarne deleted the ivarne/useDotnet6and8 branch October 10, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant