Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all test data from localtest and add a few missing mocks #362

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Add all test data from localtest and add a few missing mocks #362

merged 1 commit into from
Nov 24, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 23, 2023

No new code or tests here, but simply some infrastructure that seems to be required for testing data operations.

I think it makes a lot of sense to review this separately.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne ivarne requested a review from tjololo November 23, 2023 21:55
@ivarne ivarne added this to the 8.0.0 milestone Nov 23, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tjololo
tjololo approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@ivarne ivarne merged commit eb6ecdd into v8 Nov 24, 2023
8 checks passed
@ivarne ivarne deleted the ivarne/improve-webApplicationFactoryTests branch November 24, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Team Apps
Archived in project
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ivarne @tjololo