-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PATCH endpoint #384
New PATCH endpoint #384
Conversation
|
||
if (appLogic != true) | ||
{ | ||
_logger.LogError("Could not determine if {dataType} requires app logic for application {org}/{app}", dataType, org, app); |
Check failure
Code scanning / CodeQL
Log entries created from user input High
user-provided value
This log entry depends on a
user-provided value
|
||
if (appLogic != true) | ||
{ | ||
_logger.LogError("Could not determine if {dataType} requires app logic for application {org}/{app}", dataType, org, app); |
Check failure
Code scanning / CodeQL
Log entries created from user input High
user-provided value
|
||
public class DataController_PatchFormDataImplementation | ||
{ | ||
static Guid DataGuid = new ("12345678-1234-1234-1234-123456789123"); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note test
public class DataController_PatchFormDataImplementation | ||
{ | ||
static Guid DataGuid = new ("12345678-1234-1234-1234-123456789123"); | ||
static Guid InstanceGuid = new ("12345678-1234-1234-1234-123456789124"); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note test
const string App = "endring-av-navn"; | ||
const int InstanceOwnerPartyId = 4766; | ||
const string InstanceOwnerId = "4766"; | ||
private Mock<IDataProcessor> _dataProcessor = new(MockBehavior.Strict); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note test
const int InstanceOwnerPartyId = 4766; | ||
const string InstanceOwnerId = "4766"; | ||
private Mock<IDataProcessor> _dataProcessor = new(MockBehavior.Strict); | ||
private Instance instance = new (); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note test
Quality Gate failedFailed conditions 59.9% Coverage on New Code (required ≥ 65%) |
Implement a new PATCH endpoint using https://docs.json-everything.net/path/basics/
This is an early version that reverts most of #329, because this is a replacement solution and I don't want to add functionality that we don't indent do use. It does not (yet) attach to validations and the
IDataProcessor
don't have the oldModel argument.Related Issue(s)
Verification
Documentation