Add tests for data element Post and fix bug with AbandonChanges

[ivarne]

Fix a bug where you had to add more than 1 issues (instead of at least 1 issue) in AbandonAllChanges.

Related Issue(s)

• This includes tests for Implement IInstanceDataMutator.AbandonAllChanges #870

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

[martinothamar]

Woops, missed this. Maybe a good candidate for making a HasAbandonIssues prop to keep the conditional only one place?

[ivarne]

Maybe a good candidate for making a HasAbandonIssues prop to keep the conditional only one place?

Or just a ProblemDetails GetAbandonResponse() to internalise the mapping to a ProblemDetails instance as well?

[martinothamar]

I would not use the ASP.NET Core ProblemDetails model directly in there, I think that responsibility (deciding what to return in the API) should lie in the API/outer layer. Maybe an extension method or something?

The IInstanceMutator property could be something like HasAbandonIssues(out IEnumerable<AbandonIssue> issues) to access the actual data?

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
74.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud