Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick/836: footer title for text resource bindings #896

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Cherry-pick/836: footer title for text resource bindings #896

merged 2 commits into from
Nov 8, 2024

Conversation

Magnusrm
Copy link
Contributor

@Magnusrm Magnusrm commented Nov 8, 2024 •
edited by ivarne
Loading

  • use text resource bindings to get footer title

  • update verified test file

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Magnusrm
Use text resource bindings to get footer title (#836)
c3aca9c 
* use text resource bindings to get footer title

* update verified test file
@ivarne
Copy link
Member

ivarne commented Nov 8, 2024

Will use this PR to verify that tests run on release/* branches, so no approval yet.

@ivarne ivarne added the feature Label Pull requests with new features. Used when generation releasenotes label Nov 8, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@Magnusrm Magnusrm merged commit dcd9c77 into release/v8.3 Nov 8, 2024
8 of 10 checks passed
@Magnusrm Magnusrm deleted the cherry-pick/836 branch November 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarne ivarne ivarne approved these changes

@martinothamar martinothamar Awaiting requested review from martinothamar

Assignees
No one assigned
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Magnusrm @ivarne