Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add alias ["value", 0] in addition to ["argv", 0] #929

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 27, 2024

This ended up being a somewhat larger rewrite. Not sure if I want this now, but it might come up for performance optimisations.

  • Move values to a separate interface added to context IContextValueAccessor
  • Provide ["value"] as a shortcut for ["dataModel", ["argv", 0]]

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

* Move values to a separate interface added to context `IContextValueAccessor`
* Provide `["value"]` as a shortcut for `["dataModel", ["argv", 0]]`
Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant