Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update correspondence scope #943

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

danielskovli
Copy link
Contributor

@danielskovli danielskovli commented Dec 2, 2024

Description

The CorrespondenceAuthorisationFactory originally requested a token with scope altinn:serviceowner/instances.read while authenticating with Maskinporten.

After various internal discussions, it has been decided that his method should request a altinn:serviceowner scope instead.

Additionally I took the opportunity to remove a deprecated DTO member and consolidate two near-identical exception types.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link

sonarcloud bot commented Dec 2, 2024

@danielskovli danielskovli merged commit cf3da98 into main Dec 2, 2024
15 checks passed
@danielskovli danielskovli deleted the chore/update-correspondence-scope branch December 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🧪 Test
Development

Successfully merging this pull request may close these issues.

2 participants