Add separate context for rows in expression evaluation #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarne
changed the title
ivarne
added
the
bugfix
…repeating groups Previously this was implemented as a special case, but this makes the code simpler and fixes bugs I did not understand.
ivarne
force-pushed
the
bug/expression-validation-hidden-data
branch
from
92145ea to
fd5d9c2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+59
to
+70
| if (!includeHiddenRowChildren && isHidden) | ||
| { | ||
| if (context.Component is RepeatingGroupRowComponent or RepeatingGroupComponent) | ||
| { | ||
| var hiddenRows = await childContext.GetHiddenRows(state); | ||
| var currentRow = childContext.RowIndices?[^1]; | ||
| var rowIsHidden = currentRow is not null && hiddenRows[currentRow.Value]; | ||
| if (rowIsHidden) | ||
| if (context.Component.DataModelBindings.TryGetValue("group", out var groupBinding)) | ||
| { | ||
| continue; | ||
| var indexedBinding = await state.AddInidicies(groupBinding, context); | ||
| hiddenModelBindings.Add(indexedBinding); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| } |
Check notice
Code scanning / CodeQL
Nested 'if' statements can be combined Note
ivarne
changed the title
|
bjosttveit
approved these changes
Dec 19, 2024
bjosttveit
reviewed
Dec 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend tests in ExpressionValidation app discovered that Expression validation failed on empty lists in data model.
This PR adds a check for empty list.
Related Issue(s)
Verification
Documentation