Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean Nx config #2496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: clean Nx config #2496

wants to merge 1 commit into from

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Nov 21, 2024

Proposed change

Related issues

- No issue associated -

@kpanot kpanot requested a review from a team as a code owner November 21, 2024 03:06
Copy link

nx-cloud bot commented Nov 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3cb8376. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.83%. Comparing base (4497355) to head (3cb8376).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kpanot kpanot marked this pull request as draft November 22, 2024 00:55
fix: cache for tsconfig.build changes
fix: cache for exposed schemas
@@ -32,7 +32,7 @@
"default": "./schemas/*.json"
},
".": {
"es2020": "./dist/src/public_api.js",
"module": "./dist/src/public_api.js",
"default": "./dist/src/public_api.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default should be at the end
we have a warning while compiling vscode extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants