Skip to content

Commit

Permalink
Delete the notebook tests because they are outdated. (kubeflow#808)
Browse files Browse the repository at this point in the history
* Delete the notebook tests because they are outdated.

* We have rewritten the test infra for notebooks to use Tekton.
  see:
    https://github.com/kubeflow/testing/blob/master/tekton/templates/pipelines/notebook-test-pipeline.yaml
    https://github.com/kubeflow/examples/tree/master/py/kubeflow/examples/notebook_tests

* We are also no longer regularly deploying the v1 clusters; we are no using
  blueprints so that's why the tests can no longer get credentials

* * Add the mnist notebook test as a postsubmit and periodic test.

* Fix.
  • Loading branch information
jlewi authored Jul 7, 2020
1 parent 10b34b8 commit c880fda
Show file tree
Hide file tree
Showing 8 changed files with 51 additions and 474 deletions.
47 changes: 47 additions & 0 deletions mnist/tests/mnist-nb-pipeline-run.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Demo on how to write a pipeline run.

apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
generateName: mnist-
namespace: kf-ci
labels:
pipeline: mnist-notebook
spec:
params:
# test-target-name, artifacts-gcs, and junit-path are required for
# all the PipelineRuns. For tests spawned by Prow, values of these
# params will be injected on the fly.
- name: test-target-name
value: manual-testinig
- name: artifacts-gcs
value: gs://kubeflow-ci_temp/jlewi_mnist_testing/2020-0619
- name: junit-path
value: artifacts/junit_manual-testing
- name: testing-cluster-pattern
value: 'kf-vbp-.*'
- name: testing-cluster-location
value: 'us-central1-c'
- name: notebook-output
value: gs://kubeflow-ci-deployment_ci-temp/mnist_test
- name: notebook-path
value: mnist/mnist_gcp.ipynb
resources:
- name: notebook-repo
resourceSpec:
type: git
params:
- name: url
value: https://github.com/kubeflow/examples.git
- name: revision
value: master
# The image we want to build
- name: image
resourceSpec:
type: image
params:
- name: url
value: gcr.io/kubeflow-ci-deployment/mnist-test
pipelineRef:
name: notebook-test
serviceAccountName: kf-ci
31 changes: 4 additions & 27 deletions prow_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,31 +45,8 @@ workflows:
include_dirs:
- pytorch_mnist/*

# E2E test for various notebooks
# New notebooks can just add a step to the workflow
- py_func: kubeflow.examples.create_e2e_workflow.create_workflow
name: notebooks
- tekton_run: kubeflow/examples/tests/mnist-nb-pipeline-run.yaml
name: mnist-notebook
job_types:
- periodic
- presubmit
- postsubmit
include_dirs:
- xgboost_synthetic/*
- mnist/*
- py/kubeflow/examples/notebook_tests
- py/kubeflow/examples/create_e2e_workflow.py

# E2E test for various notebooks
# New notebooks can just add a step to the workflow
- py_func: kubeflow.examples.create_e2e_workflow.create_workflow
name: notebooks-v1
job_types:
- periodic
- presubmit
- postsubmit
include_dirs:
- xgboost_synthetic/*
- mnist/*
- py/kubeflow/examples/create_e2e_workflow.py
kwargs:
cluster_pattern: kf-v1-(?!n\d\d)
- periodic
- postsubmit
56 changes: 0 additions & 56 deletions py/kubeflow/examples/notebook_tests/conftest.py

This file was deleted.

83 changes: 0 additions & 83 deletions py/kubeflow/examples/notebook_tests/execute_notebook.py

This file was deleted.

55 changes: 0 additions & 55 deletions py/kubeflow/examples/notebook_tests/job.yaml

This file was deleted.

33 changes: 0 additions & 33 deletions py/kubeflow/examples/notebook_tests/mnist_gcp_test.py

This file was deleted.

Loading

0 comments on commit c880fda

Please sign in to comment.