Fix / Resolving of Batched Routes #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sonytooo
commented
Nov 22, 2024
•
sonytooo
commented
- Fixed: https://github.com/AmbireTech/ambire-app/issues/3272
- Added network name to the bridge banners on the Dashboard
superKalo
reviewed
Nov 25, 2024
| }) | ||
| ) | ||
| } |
There was a problem hiding this comment.
What was the problem with Promise.all-ing these?
There was a problem hiding this comment.
The issue occurs because updateActiveRoute writes to this.activeRoutes. When multiple routes are updated in parallel, it causes a race condition, resulting in some routes failing to update properly
superKalo
reviewed
Nov 25, 2024
superKalo
approved these changes
Nov 25, 2024
PetromirDev
requested changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.