-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite how the emulator works, and all UIs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the `core` to never do anything platform specific, this includes UI and audio handling. Planning to remove almost all the UIs except for the new one `egui` Signed-off-by: Amjad Alsharafi <[email protected]>
Forwarded the buffer from the backend apu to the frontend ui Signed-off-by: Amjad Alsharafi <[email protected]>
Dropped_files doesn't work on wayland `winit` at the time of writing, but works on X11, so we can use that for now. Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
TUI doesn't work yet with the new API, but should soon. Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Amjad50
force-pushed
the
rewrite
branch
3 times, most recently
from
October 19, 2024 02:56
c2a2d16
to
cd5c690
Compare
I think I was testing something and left it there by mistake Signed-off-by: Amjad Alsharafi <[email protected]>
Amjad50
force-pushed
the
rewrite
branch
10 times, most recently
from
October 19, 2024 03:41
5210809
to
af3bdc2
Compare
Signed-off-by: Amjad Alsharafi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
===========================================
+ Coverage 43.80% 81.83% +38.03%
===========================================
Files 34 37 +3
Lines 2744 5351 +2607
===========================================
+ Hits 1202 4379 +3177
+ Misses 1542 972 -570 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very big PR here.
This does several things.
NES
was holding everything, and even managing rendering throughUiProvider
trait. I didn't like this design.So I adopted the new design that I also used in my other emulators mizu and trapezoid.
This new design is that the emulator is in a crate
plastic_core
this makes it much easier for others to just import this and handle emulation without needing to implementUiProvider
.You can think of this new design in that the emulator is now a service provider providing you with pixels and audio and you just provide input and clock it.
egui
. one UI is just better, and non of the above 3 is good for all platforms, tbh not sure ifegui
is good with other platforms but it seems simple so I think it should work with all platforms easily.tui
ui to work with the new design of the emulator and updated its deps (ratatui)save/load state