Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to release the crate (as a crate, not github release) #7

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

Amjad50
Copy link
Owner

@Amjad50 Amjad50 commented Oct 19, 2024

Some cleanup

  • renamed the crates to plastic (UI) and plastic_tui for tui
  • updated docs and public API
  • removed unused code and make it easier to use the API

@Amjad50 Amjad50 force-pushed the cleanup_and_release branch from b5f75bc to e88ab27 Compare October 19, 2024 04:14
Signed-off-by: Amjad Alsharafi <[email protected]>
@Amjad50 Amjad50 force-pushed the cleanup_and_release branch from e88ab27 to 5978b3e Compare October 19, 2024 04:20
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.86%. Comparing base (619b588) to head (5c08e2e).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
plastic_core/src/controller/mod.rs 16.66% 5 Missing ⚠️
plastic_core/src/nes.rs 0.00% 5 Missing ⚠️
plastic_core/src/apu2a03/mod.rs 0.00% 2 Missing ⚠️
plastic_core/src/ppu2c02/mod.rs 0.00% 2 Missing ⚠️
plastic_core/src/common/save_state.rs 0.00% 1 Missing ⚠️
plastic_core/src/cpu6502/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   81.83%   81.86%   +0.03%     
==========================================
  Files          37       37              
  Lines        5351     5349       -2     
==========================================
  Hits         4379     4379              
+ Misses        972      970       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This excludes the `misc` module by default as its used only by me

Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
@Amjad50 Amjad50 merged commit 171b71c into master Oct 19, 2024
3 of 4 checks passed
@Amjad50 Amjad50 deleted the cleanup_and_release branch October 19, 2024 06:48
@Amjad50 Amjad50 restored the cleanup_and_release branch October 19, 2024 11:27
@Amjad50 Amjad50 deleted the cleanup_and_release branch October 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant