-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First Commit(Animations added) #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
Please follow these guidelines for smooth collaboration:
- After completing a task, add your name and details to the Contributors Table/List.
- Attach relevant screenshots or videos of your contribution for transparency.
- Tasks are assigned on a first-come, first-served basis.
- Avoid spamming requests for already-assigned tasks.
- Respect the queue and wait for new tasks.
- Propose New Ideas: Discuss new features or suggestions in the "Ideas" channel before starting work.
@Amna-Hassan04 |
@Amna-Hassan04 can you look into the PR and Merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you havent added a video that would show if the animations happen for a second or so and disappear or not. plus according to the screenshots the animations look unnecessary if the the images are just going to stay. I dont know really how they will look in the app unless you link a video showcasing them. and didnt I ask u to show me a sample of how the animations would look before making a PR?
@Amna-Hassan04, Here is the vedio of the animations added : Screen-Recording.1.mp4 |
Added the vedio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Animated emojis are too big. they should be either alligned inside the button or next to it in the same size as the button so they look good. your pr should disturb the overall aesthetic of the app
@Coder-mania plz make the proposed changes so i might be able to merge this before gssoc ends. |
@Coder-mania have you made the necessary changes that Amna suggested? If not than do it asap so that she can merge it before this ends. Make sure it passes all the tests. |
@Amna-Hassan04 kindly look into this. |
@Coder-mania no screenshot attached for the updated code. and your commit is much behind the main repo |
No reply from all most 2 weeks, closing this pr, if the changes are made plz make a new pr. |
Hello there! @Amna-Hassan04
-> Done with the adding of animations.
-> Also a transition to button.
Below are the screenshots/video :