Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar enhanced with same color scheme #198

Closed
wants to merge 3 commits into from

Conversation

Saaarthak0102
Copy link

Enhanced the navbar with better design!

Fixes Issue #148

image

@Saaarthak0102
Copy link
Author

please review and merge! @Amna-Hassan04

Copy link
Author

@Saaarthak0102 Saaarthak0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@zoobiasyed
Copy link
Collaborator

@Amna-Hassan04 merge it as it's completed, do check it before merging.

@Saaarthak0102
Copy link
Author

Hey! Its been a week.
Please review and merge @Amna-Hassan04

@Amna-Hassan04 Amna-Hassan04 self-requested a review November 8, 2024 03:57
@Amna-Hassan04 Amna-Hassan04 linked an issue Nov 8, 2024 that may be closed by this pull request
Copy link
Owner

@Amna-Hassan04 Amna-Hassan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the navbar to be improved but not lose its original style that looks good. This looks very bland, if u want this to be merged you have make the navbar look like the previous one just improve it in some way which would be better.

@Saaarthak0102
Copy link
Author

I want the navbar to be improved but not lose its original style that looks good. This looks very bland, if u want this to be merged you have make the navbar look like the previous one just improve it in some way which would be better.

Oh... I thought this one is better and I guess there's no way we can improvise the real one. Thank you for letting me try! 😊

@zoobiasyed
Copy link
Collaborator

@Saaarthak0102 thank you for your hard work and the improvised version, but as mentioned my Amna kindly make the original one better so she can merge it asap.

@aslams2020
Copy link

@Amna-Hassan04
This PR has been merged by the GSSoC team
here - sanjay-kv/Open-source-Practice#1369

Don't add labels to it now.

@Saaarthak0102 You'll get the points in the leaderboard update.

@aslams2020
Copy link

You can close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Better navbar
4 participants