Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings management for custom render and remove #199

Closed
wants to merge 3 commits into from

Conversation

RickButler
Copy link
Collaborator

This is an extension of #181 and the work of @herkyl

resloves #180

The tests I wrote are the simplest way I could accomplish testing whether downset/upsert were called in custom render functions. I didn't bother keeping a render count because that is covered in:

test('event behavior with over-ridden `render` & `remove` fns', function (t) {

I'm back and forth between making this a major/minor SemVer change when this is released. Leaning towards major version bump. I think this qualifies as a breaking change, assuming you had custom render/remove and for whatever reason didn't want to call upsert/downsert for bindings.

Since I made changes here, looking for a +1 from someone else.

@RickButler RickButler changed the title Bindings management for bustom render and remove Bindings management for custom render and remove Jun 2, 2018
@RickButler
Copy link
Collaborator Author

closing this, didn't realize I had the ability to push to @herkyl fork.

@RickButler RickButler closed this Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants