Bindings management for custom render and remove #199
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #181 and the work of @herkyl
resloves #180
The tests I wrote are the simplest way I could accomplish testing whether downset/upsert were called in custom render functions. I didn't bother keeping a render count because that is covered in:
ampersand-view/test/main.js
Line 43 in f632021
I'm back and forth between making this a major/minor SemVer change when this is released. Leaning towards major version bump. I think this qualifies as a breaking change, assuming you had custom render/remove and for whatever reason didn't want to call upsert/downsert for bindings.
Since I made changes here, looking for a +1 from someone else.