Write an evaluation of this approach #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
evaluation
branch
3 times, most recently
from
71cf14b to
aac1ea7
Compare
Have a look at how I understand how the microservice works and the comparison at the bottom of the file. Please correct me if I get it wrong and feel free to answer my open questions. I think the big advantage of this microservice is that we don't have to settle for a fixed size of image resolutions but have some sort of microservice which is doing the conversion on the fly. However I believe this microservice adds a lot of complexity to our code base. Currently I don't see the justification for it if we can more or less achieve the same behaviour *without any self-written service*.
AndreiBu
reviewed
Jan 10, 2020
| I get: | ||
| ``` | ||
| You need to set up the project dependencies using the following commands: | ||
| curl -sS https://getcomposer.org/installer | php |
There was a problem hiding this comment.
I followed those steps and got the error message mentioned in this PR.
| ``` | ||
|
|
||
| I can access [localhost:8000](http://localhost:8000/) but the health check on [localhost:8000/health-check](http://localhost:8000/health-check) seems broken, I get HTTP 500 error and the message: "This page isn’t working" in Chromium. | ||
|
|
| [ws.human-connection.social/api/docs](https://ws.human-connection.social/api/docs)? | ||
| I would like to upload a file through the swagger web interface. | ||
| * Are requests to `/cdn/thumbnail/by-url` cached in some way? Like, are the | ||
| thumbnails saved on disk? |
There was a problem hiding this comment.
this is only alpha version to the demonstration
all config can put in to .env file with basis .env.example
mysql and phpmyadmin only for local and demo installation - in live we not need him
| | we add extra services on kubernetes (mysql, phpmyadmin) | no self-hosted services | | ||
| | ImageMagick for image resizing | sharp uses libvips - [they claim it's faster](https://github.com/lovell/sharp#sharp) | | ||
| | we have to configure a CDN on our own | Digital Ocean's CDN out of the box| | ||
|
|
There was a problem hiding this comment.
I am not ready to provide a token for saving any files to my private server
cache and any data storage on my server for this reason are disabled in the demo
it all look notfriendly and like a desire to make any decision on PHP or from other developers !!!! :)
it is a microservice and the network can only use it through API and no matter what language it works in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a look at how I understand how the microservice works and the comparison
at the bottom of the file. Please correct me if I get it wrong and feel free to
answer my open questions. I think the big advantage of this microservice
is that we don't have to settle for a fixed size of image resolutions
but have some sort of microservice which is doing the conversion on the
fly. However I believe this microservice adds a lot of complexity to our
code base. Currently I don't see the justification for it if we can more or
less achieve the same behaviour without any self-written service.