Skip to content

Commit

Permalink
Default skip_if_noop of gripper open()/close() to False (#36)
Browse files Browse the repository at this point in the history
* Default `skip_if_noop` of gripper `open()`/`close()` to False

Signed-off-by: Andrej Orsula <[email protected]>

---------

Signed-off-by: Andrej Orsula <[email protected]>
  • Loading branch information
AndrejOrsula authored Oct 4, 2023
1 parent 4f00642 commit 0bb938c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions pymoveit2/gripper_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def toggle(self):
else:
self.open(skip_if_noop=False)

def open(self, skip_if_noop: bool = True):
def open(self, skip_if_noop: bool = False):
"""
Open the gripper.
- `skip_if_noop` - No action will be performed if the gripper is already open.
Expand All @@ -165,7 +165,7 @@ def open(self, skip_if_noop: bool = True):

self.__send_goal_async_gripper_command(self.__open_gripper_command_goal)

def close(self, skip_if_noop: bool = True):
def close(self, skip_if_noop: bool = False):
"""
Close the gripper.
- `skip_if_noop` - No action will be performed if the gripper is not open.
Expand Down
4 changes: 2 additions & 2 deletions pymoveit2/gripper_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def toggle(self):
else:
self.open(skip_if_noop=False)

def open(self, skip_if_noop: bool = True):
def open(self, skip_if_noop: bool = False):
"""
Open the gripper.
- `skip_if_noop` - No action will be performed if the gripper is already open.
Expand All @@ -111,7 +111,7 @@ def open(self, skip_if_noop: bool = True):

self._interface.open(self=self, skip_if_noop=skip_if_noop)

def close(self, skip_if_noop: bool = True):
def close(self, skip_if_noop: bool = False):
"""
Close the gripper.
- `skip_if_noop` - No action will be performed if the gripper is not open.
Expand Down
4 changes: 2 additions & 2 deletions pymoveit2/moveit2_gripper.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def toggle(self):
else:
self.open(skip_if_noop=False)

def open(self, skip_if_noop: bool = True):
def open(self, skip_if_noop: bool = False):
"""
Open the gripper.
- `skip_if_noop` - No action will be performed if the gripper is already open.
Expand All @@ -139,7 +139,7 @@ def open(self, skip_if_noop: bool = True):
joint_positions=self.__open_gripper_joint_positions
)

def close(self, skip_if_noop: bool = True):
def close(self, skip_if_noop: bool = False):
"""
Close the gripper.
- `skip_if_noop` - No action will be performed if the gripper is not open.
Expand Down

0 comments on commit 0bb938c

Please sign in to comment.