Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/string error codes #83

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

blooop
Copy link
Contributor

@blooop blooop commented Feb 19, 2025

This improves the warning and error messages by printing the string value of the return code rather than the number. It uses a generic method for working out the appropriate string to print so that its easier to apply to any message type. That is probalby not optimal for performance but is simpler to integrate and is likely insignificant compared to time for other operations.

I've been using it for a week with no issues.

@AndrejOrsula
Copy link
Owner

This is very helpful. Thanks a lot, @blooop!

@blooop blooop requested a review from AndrejOrsula February 19, 2025 10:57
Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good!

@AndrejOrsula AndrejOrsula merged commit b8dde85 into AndrejOrsula:master Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants