Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix build #141

wants to merge 3 commits into from

Conversation

derMart
Copy link

@derMart derMart commented Mar 23, 2020

Fix #140 Fix #139 Fix #138 Fix #73 Fix #54

replace xz compression with gzip as this is the default and xz is not 
working
@derMart
Copy link
Author

derMart commented Mar 23, 2020

@Androxyde this is just a suggestion which fixes a lot of build related issues and updates the BUILD.md documentation. Building from scratch without eclipse is working and tested in linux. I added an ant build file which actually generates the x10flasher.jar. This is basically just exported from within eclipse and copied into the ant subdirectory (changing the project baseDir in the .xml). The build file can be easily maintained as such.

@sandikodev
Copy link

how i can use this pull request

@derMart
Copy link
Author

derMart commented May 17, 2020

@mh4nx7net clone https://github.com/derMart/Flashtool/tree/fix_build and look at BUILD.md

@sandikodev
Copy link

yes, I have, but there still had alot of error :(
grimshoot-slurp-2020-05-18-08-35-10

@derMart
Copy link
Author

derMart commented May 18, 2020

sorry, I can not reproduce the problem. Tried running from a fairly virgin Ubuntu 18.04.4 with respect to java build tools. Compilation runs without errors.
Using ubuntu openjdk-11-jdk and ant packages (javac --version: javac 11.0.7, ant -version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019) and most probably no other java related dependency installed...

EDIT: can you show the complete ant output?

@Hurricos
Copy link

This Dockerfile works:

from ubuntu:focal

# tzdata fix: https://anonoz.github.io/tech/2020/04/24/docker-build-stuck-tzdata.html
RUN apt update && \
        DEBIAN_FRONTEND=noninteractive \
        TZ=Asia/Singapore \
        apt install -y openjdk-14-jdk p7zip-full ant git

WORKDIR /Flashtool

RUN git clone https://github.com/Androxyde/Flashtool . && git checkout 56528c0795676d9f3362e288a11435bd2abe00bf

# Follow BUILD.md now ..

# We need to fetch and merge https://github.com/Androxyde/Flashtool/pull/141
RUN git remote add fix https://github.com/derMart/Flashtool && git pull fix fix_build

# The new BUILD.md:
# https://github.com/derMart/Flashtool/blob/fix_build/BUILD.md

RUN ant -buildfile ant/build-jar.xml
RUN ant -buildfile ant/deploy-release.xml
RUN ant -buildfile ant/setup-release.xml

@derMart, I will prepare a PR against your fix_build, adding build/ directory containing a Dockerfile and Makefile capable of building the releases.

@Hurricos
Copy link

PR here: derMart#1

@derMart You should probably refresh your patches against the master branch too.

@Hurricos
Copy link

All this having been said, it seems that given the number of dependencies required the better way to do this would be to use what package maintainers provide: https://salsa.debian.org/java-team/xperia-flashtool

@Androxyde
Copy link
Owner

Hello,
Flashtool can be built with any JDK release from JDK 11
Here are the steps

Post step : Having a full jdk installed with minimum release 11 and Having ant installed
Here are packages installed on my side :
java-11-openjdk-headless-11.0.9.11-9.fc33.x86_64
java-11-openjdk-11.0.9.11-9.fc33.x86_64
java-11-openjdk-devel-11.0.9.11-9.fc33.x86_64
I used ant from Apache Ant website : (https://ant.apache.org/bindownload.cgi)
Apache Ant(TM) version 1.10.9 compiled on September 27 2020

Step 1 : clone the git repository : git clone https://github.com/Androxyde/Flashtool
Step 2 : goto directory Flashtool/ant
Step 3 : export CLASSPATH=./nsisant-1.3.jar:./xz-1.8.jar
Step 4 (only if the required java release is not in your PATH or the one in your PATH is not the right release) : export JAVA_HOME=/usr/lib/jvm/java-11-openjdk-11.0.9.11-9.fc33.x86_64 (this path is mine on applies only to my case)
Step 5 : ant -f deploy-release.xml
Step 6 : ant -f setup-release.xml

And it's finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment