Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Consistent Card Height for Better Presentation. #105

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

grasyPatel
Copy link
Contributor

Description

This pull request addresses the issue of inconsistent card heights in the home page section of the website. The changes ensure that all cards are of the same height and maintain a responsive design for better presentation.

Related Issues

Type of PR

  • [ X] (Bug)
  • [ X] (Enhancement)

Screenshots / videos (if applicable)

Screenshot 2024-10-02 at 11 51 36 PM

Checklist

  • [ X] I have gone through the contributing guide
  • [X ] I have updated my branch and synced it with project main branch before making this PR
  • [X ] I have performed a self-review of my code
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • [X ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ X] I have commented my code, particularly in hard-to-understand areas.

Additional context:

The changes leverage flexbox properties to maintain consistent heights across all cards, allowing for a clean layout on both desktop and mobile screens. This will improve the user experience and presentation of the content.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @grasyPatel! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 4da6b95
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/66fdb6ba6415a200081c4013
😎 Deploy Preview https://deploy-preview-105--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51
Copy link
Owner

@grasyPatel please check below image is overflowed.

image

@Anjaliavv51
Copy link
Owner

@grasyPatel please check our chnages in the below deploy preview link.

image

@grasyPatel
Copy link
Contributor Author

@Anjaliavv51 I have made it responsive ,let me know if it requires any changes.

@Anjaliavv51 Anjaliavv51 merged commit b220f0a into Anjaliavv51:main Oct 3, 2024
6 checks passed
Copy link

github-actions bot commented Oct 3, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[bug]: Ensure Consistent Card Height for Better Presentation.
2 participants