-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨[feature Request]: Changing Navbar #186 #222
✨[feature Request]: Changing Navbar #186 #222
Conversation
…line with glowing effect and added much more features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Mayukh-Mandal2005! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for rococo-mooncake-0d89f7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @Anjaliavv51 |
In our collection their are some correction need to be changed. |
What needs to be changed? |
@Anjaliavv51 |
@Anjaliavv51 |
@Mayukh-Mandal2005 no need it's fine , did u implement it to all html pages. |
Yes @Anjaliavv51 Mam |
And also one last implement it to it to electronics.html page too ,located inside htmlfiles folder please check |
@Anjaliavv51 |
@Mayukh-Mandal2005 I am saying to implement navbar even to that page. |
@Mayukh-Mandal2005 their is overflow in about , collection , |
@Mayukh-Mandal2005 only index.html page navbar is properly aligned , for remaining all , it has an overflow , please check and also implement navbar for electronics page to , check below ss |
@Anjaliavv51 |
@Mayukh-Mandal2005 it's not looking good try to adjust and also in some pages collections or about or service link is not provided. |
I tried to improve that condition though in every possible way but could not do the same |
@Anjaliavv51 |
okay , then i will merge. |
If you want me to include all the tabs on all the pages i will do the same right now |
include all but avoid signup and login and cart image to other pages , except index.html page. |
Alright @Anjaliavv51 Mam |
@Mayukh-Mandal2005 why retro word is not aligned properly? in service , contact ,menu ,about. |
@Anjaliavv51 |
I am checking it although once again if I can adjust and will update you about the same |
okay , is everthing done now , i will merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
@Mayukh-Mandal2005 mention the issue number inside pr description. |
Hey @Anjaliavv51 |
Create another PR on same issue. |
@Anjaliavv51 Mam |
Yes I assigned it to you |
Description
Updated the Navbar UI as asked in the issue column
Added rounded corners with white background, underline and glowing effect on the tabs in navbar of each page with adding 1-2 more features such as cart image with count option on each page
Related Issues
Type of PR
Screenshots / videos (if applicable)
Image of website before the Navbar UI -
Images of website after the updated Navbar UI-
Checklist
main
branch before making this PRAdditional context: