Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[feature Request]: Changing Navbar #186 #222

Merged
merged 4 commits into from
Oct 5, 2024
Merged

✨[feature Request]: Changing Navbar #186 #222

merged 4 commits into from
Oct 5, 2024

Conversation

Mayukh-Mandal2005
Copy link
Contributor

@Mayukh-Mandal2005 Mayukh-Mandal2005 commented Oct 5, 2024

Description

Updated the Navbar UI as asked in the issue column
Added rounded corners with white background, underline and glowing effect on the tabs in navbar of each page with adding 1-2 more features such as cart image with count option on each page

Related Issues

Type of PR

  • [✔️ ] (Feature update, Code Refactor)

Screenshots / videos (if applicable)

Image of website before the Navbar UI -
image

Images of website after the updated Navbar UI-
image
image

Checklist

  • [✔️ ] I have gone through the contributing guide
  • [✔️ ] I have updated my branch and synced it with project main branch before making this PR
  • [ ✔️] I have performed a self-review of my code
  • [ ✔️] I have tested the changes thoroughly before submitting this pull request.
  • [ ✔️] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ ✔️] I have commented my code, particularly in hard-to-understand areas.

Additional context:

…line with glowing effect and added much more features
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Mayukh-Mandal2005! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 738e9c0
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/67014ffae66b1700092f63e7
😎 Deploy Preview https://deploy-preview-222--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mayukh-Mandal2005
Copy link
Contributor Author

Hey @Anjaliavv51
Kindly check and merge the PR please.

@Anjaliavv51
Copy link
Owner

In our collection their are some correction need to be changed.

@Mayukh-Mandal2005
Copy link
Contributor Author

Mayukh-Mandal2005 commented Oct 5, 2024

What needs to be changed?
Kindly specify the issue @Anjaliavv51 mam

@Mayukh-Mandal2005
Copy link
Contributor Author

@Anjaliavv51
Kindly tell issues so I can make the necessary rectifications ASAP

@Mayukh-Mandal2005
Copy link
Contributor Author

@Anjaliavv51
Kindly tell what changes need to be made so I can complete the tasks please.

@Anjaliavv51
Copy link
Owner

@Mayukh-Mandal2005 no need it's fine , did u implement it to all html pages.

@Mayukh-Mandal2005
Copy link
Contributor Author

Mayukh-Mandal2005 commented Oct 5, 2024

Yes @Anjaliavv51 Mam
I have implemented to all HTML Pages as told by you Home, About, Services, Collection, Contact Us
I did not include on payment, sign up and login in pages as ordered by you

@Anjaliavv51
Copy link
Owner

And also one last implement it to it to electronics.html page too ,located inside htmlfiles folder please check

@Mayukh-Mandal2005
Copy link
Contributor Author

@Anjaliavv51
So should I close this pull request and make a new one?

@Anjaliavv51
Copy link
Owner

@Mayukh-Mandal2005 I am saying to implement navbar even to that page.

@Anjaliavv51
Copy link
Owner

@Mayukh-Mandal2005 their is overflow in about , collection ,

image

image

@Anjaliavv51
Copy link
Owner

@Mayukh-Mandal2005 only index.html page navbar is properly aligned , for remaining all , it has an overflow , please check and also implement navbar for electronics page to , check below ss

image

@Mayukh-Mandal2005
Copy link
Contributor Author

@Anjaliavv51
No actually that's the design which is being implemented by bootstrap and I guess home page looks and other pages looks are similar
And tbh the overflow condition gives a great look for the pages as when you click the Retro logo it takes you to the home page

@Anjaliavv51
Copy link
Owner

@Mayukh-Mandal2005 it's not looking good try to adjust and also in some pages collections or about or service link is not provided.

@Mayukh-Mandal2005
Copy link
Contributor Author

I tried to improve that condition though in every possible way but could not do the same
There is bootstrap style being getting overriden with the css files
I hope you understand @Anjaliavv51 Mam

@Mayukh-Mandal2005
Copy link
Contributor Author

@Anjaliavv51
Yeah I did not provide the links in those pages which are same as that page
For example - If you are on services page, then we do not need a services tab for that as we are on that page only
I hope that helps

@Anjaliavv51
Copy link
Owner

I tried to improve that condition though in every possible way but could not do the same There is bootstrap style being getting overriden with the css files I hope you understand @Anjaliavv51 Mam

okay , then i will merge.

@Mayukh-Mandal2005
Copy link
Contributor Author

Mayukh-Mandal2005 commented Oct 5, 2024

If you want me to include all the tabs on all the pages i will do the same right now
No issues @Anjaliavv51 Mam

@Anjaliavv51
Copy link
Owner

If you want me to include all the tabs on all the pages i will do the same right now No issues

include all but avoid signup and login and cart image to other pages , except index.html page.

@Mayukh-Mandal2005
Copy link
Contributor Author

Alright @Anjaliavv51 Mam
I will do that right away

@Anjaliavv51
Copy link
Owner

@Mayukh-Mandal2005 why retro word is not aligned properly? in service , contact ,menu ,about.

image

@Mayukh-Mandal2005
Copy link
Contributor Author

@Anjaliavv51
Mam as I mentioned before this is due to the css styles being getting overriden with the bootstrap styles
I tried to sync it with other elements in all ways but it did not work like the way we wanted

@Mayukh-Mandal2005
Copy link
Contributor Author

I am checking it although once again if I can adjust and will update you about the same

@Anjaliavv51
Copy link
Owner

I am checking it although once again if I can adjust and will update you about the same

okay , is everthing done now , i will merge it.

Copy link
Owner

@Anjaliavv51 Anjaliavv51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@Anjaliavv51 Anjaliavv51 merged commit f833854 into Anjaliavv51:main Oct 5, 2024
6 checks passed
Copy link

github-actions bot commented Oct 5, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@Anjaliavv51
Copy link
Owner

@Mayukh-Mandal2005 mention the issue number inside pr description.

@Mayukh-Mandal2005
Copy link
Contributor Author

Hey @Anjaliavv51
I found the problem and fixed it but I am not able to merge the commits in the PR now :(

@Anjaliavv51
Copy link
Owner

Hey @Anjaliavv51 I found the problem and fixed it but I am not able to merge the commits in the PR now :(

Create another PR on same issue.

@Mayukh-Mandal2005
Copy link
Contributor Author

@Anjaliavv51 Mam
Created
Please check

@Anjaliavv51
Copy link
Owner

Yes I assigned it to you

@Mayukh-Mandal2005 Mayukh-Mandal2005 deleted the updated-navbar branch October 5, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[feature Request]: Changing Navbar
2 participants