Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed text boxes gap & Header issue ! #432 #506

Closed
wants to merge 1 commit into from

Conversation

Subhajit-2023-44
Copy link
Contributor

@Subhajit-2023-44 Subhajit-2023-44 commented Oct 13, 2024

Hello PR,
Fixed issue number - #432

All Issue Fixed -

Text boxes issue -
Screenshot 2024-10-13 202210
Screenshot 2024-10-13 202224

Header Issue -
Screenshot 2024-10-13 203307
Screenshot 2024-10-13 203324
Screenshot 2024-10-13 204019

Type of PR

  • ()

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Subhajit-2023-44! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 585146d
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/670be4d9856c6400084c166d
😎 Deploy Preview https://deploy-preview-506--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Subhajit-2023-44
Copy link
Contributor Author

@Anjaliavv51 PA kindly add level 2
because I fixed all these two main issue properly & also I don't got any level for this(#378) merge.

@Anjaliavv51
Copy link
Owner

@Subhajit-2023-44 create some other issue , these changes are not required sorry for the inconvience.

@Subhajit-2023-44
Copy link
Contributor Author

But @Anjaliavv51 ma'am you assigned me for this issue..

Screenshot 2024-10-13 210102

I Fixed these issue - #432
When the cursor is moved to the "Retro Vibe is Good Vibe" text box, the text box merges with the "SIGN UP" text box. which doesn't look very good.
& the position of the Header is fixed across the page, causing it to blend in with other text, It preventing the website from looking better.

@Anjaliavv51
Copy link
Owner

But @Anjaliavv51 ma'am you assigned me for this issue..

Screenshot 2024-10-13 210102

I Fixed these issue - #432 When the cursor is moved to the "Retro Vibe is Good Vibe" text box, the text box merges with the "SIGN UP" text box. which doesn't look very good. & the position of the Header is fixed across the page, causing it to blend in with other text, It preventing the website from looking better.

yes but now it is not required , so please mention ur issue properly

@Subhajit-2023-44
Copy link
Contributor Author

@Anjaliavv51 ma,am I mention my issue properly & also attached issue video & ss #432.. & you assigned me for this issue but now you said ...

@Anjaliavv51
Copy link
Owner

@Anjaliavv51 ma,am I mention my issue properly & also attached issue video & ss #432.. & you assigned me for this issue but now you said ...

Sorry it's my mistake I didn't get u properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants