Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[feature Request]: Signup page UI does not matches with the Login page UI #613

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

amitroy-thedev
Copy link
Contributor

@amitroy-thedev amitroy-thedev commented Oct 16, 2024

Description

Related Issues

Type of PR

  • ()

Screenshots / videos (if applicable)

Before :
image

After :
image
Same UI as Login Page
image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @amitroy-thedev! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit fc015a6
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/6710a31593f80200081b257c
😎 Deploy Preview https://deploy-preview-613--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amitroy-thedev
Copy link
Contributor Author

@Anjaliavv51 I've made the changes you can review it, in the new code i have deleted login page and register page css and combined them together in a new css file

@Anjaliavv51
Copy link
Owner

Anjaliavv51 commented Oct 16, 2024

@amitroy-thedev u need to make login colors(pink color UI) same as signup , implement structure of login page

@amitroy-thedev
Copy link
Contributor Author

amitroy-thedev commented Oct 16, 2024

@Anjaliavv51 make the login, signup and google buttons pink?
like this
image
image

@Anjaliavv51
Copy link
Owner

@amitroy-thedev yes

@amitroy-thedev
Copy link
Contributor Author

@Anjaliavv51 Done

@amitroy-thedev
Copy link
Contributor Author

@Anjaliavv51 I've made the changes would you review and merge it

@Anjaliavv51 Anjaliavv51 merged commit ae0a9a3 into Anjaliavv51:main Nov 2, 2024
8 checks passed
Copy link

github-actions bot commented Nov 2, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[feature Request]: Signup page UI does not matches with the Login page UI
3 participants