Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Icon Overlap and Alphabet Input Allowed in Phone Number Field #87

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

rahulgithub-web
Copy link
Contributor

[bug]: Icon Overlap and Alphabet Input Allowed in Phone Number Field

Description

This pull request fixes the following issues:

  1. Icon overlap: The input text was overlapping with the icons in the email, phone number, and name fields. Padding has been adjusted to ensure proper alignment between the icons and the input text.
  2. Alphabet input in the phone number field: The phone number field was previously accepting alphabetic characters. The input type has been changed to tel, and a validation pattern has been added to restrict input to only numeric characters.

Related Issues

Type of PR

  • Bugfix

Screenshots / Videos (if applicable)

Before Fix:
image

After Fix:
image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with the project main branch before making this PR.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context:

None

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @rahulgithub-web! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 10e5f50
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/66fd447af1e57800088da50e
😎 Deploy Preview https://deploy-preview-87--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51 Anjaliavv51 added bug Something isn't working enhancement New feature or request gssoc-ext Level 1 hacktoberfest-accepted labels Oct 2, 2024
@Anjaliavv51 Anjaliavv51 merged commit 63c1d7b into Anjaliavv51:main Oct 2, 2024
7 checks passed
Copy link

github-actions bot commented Oct 2, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request gssoc-ext hacktoberfest-accepted Level 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[bug]: Icon Overlap and Alphabet Input Allowed in Phone Number Field
3 participants