Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupy tuturial add two segments #524

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Jupy tuturial add two segments #524

merged 2 commits into from
Oct 16, 2024

Conversation

pydanny
Copy link
Collaborator

@pydanny pydanny commented Oct 16, 2024


name: Pull Request
about: Propose changes to the codebase
title: '[PR] Jupy tuturial add two segments'
labels: 'documentation'
assignees: ''


Related Issue

#487 [DOCS] More features for the Jupyter+FastHTML demo

Proposed Changes

An abridged version of an earlier PR, adds two segments to docs:

  • Full screen view
  • Graceful shutdowns

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information

This PR is intentionally small and designed to be easy for avoiding merge conflicts.

@pydanny pydanny requested a review from jph00 October 16, 2024 07:57
Copy link

gitnotebooks bot commented Oct 16, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/524

@pydanny pydanny force-pushed the jupy-tut-two-segments branch from 8ad94f6 to f01e114 Compare October 16, 2024 08:00
@jph00
Copy link
Contributor

jph00 commented Oct 16, 2024

Thank you :)

@jph00 jph00 merged commit f0bde8c into main Oct 16, 2024
2 checks passed
@jph00 jph00 deleted the jupy-tut-two-segments branch October 16, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants