Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue #565, improper initialization of multiple select and checkbox arrays #566

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

lnoor
Copy link
Contributor

@lnoor lnoor commented Nov 5, 2024


name: Pull Request
about: Propose changes to the codebase
title: '[PR] '
labels: ''
assignees: ''


Related Issue
Please link to the issue that this pull request addresses. If there isn't one, please create an issue first.

#565

Proposed Changes
Describe the big picture of your changes here. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Modified _fill_item() to resolve the issue.
Included tests to show proper operation.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Copy link

gitnotebooks bot commented Nov 5, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/566

@jph00
Copy link
Contributor

jph00 commented Nov 18, 2024

Thanks @lnoor ! Your PR has deleted outputs from the cells, which means that won't show up in the docs. Could you please re-run the notebook to generate the outputs?

@lnoor
Copy link
Contributor Author

lnoor commented Nov 19, 2024

Hi @jph00,
I updated the commit, sorry to put you to work for nothing.
I'm a Jupyter and nbdev virgin so still learning the ropes.

@jph00
Copy link
Contributor

jph00 commented Nov 19, 2024

Great job! And no apologies required :D

@jph00 jph00 merged commit 803d974 into AnswerDotAI:main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants