Skip to content

WIP Add option to remove cell header comment lines on export, fixes #965 #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dmose
Copy link

@dmose dmose commented Dec 28, 2022

Posting for feedback in #965 on if/how to surface this option to end-users.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dmose dmose changed the title WIP Add option to remove cell header comment lines on export, fixes #963 WIP Add option to remove cell header comment lines on export, fixes #965 Jan 11, 2023
@dmose dmose force-pushed the 965-remove-cell-nums-option branch from 414c5f7 to 3780b52 Compare February 11, 2023 20:41
@hamelsmu
Copy link
Contributor

This is still marked as WIP and is old, closing (but feel to reopen if you get to it!)

@hamelsmu hamelsmu closed this Feb 27, 2025
@dmose
Copy link
Author

dmose commented Mar 9, 2025

@hamelsmu this was stalled because it was waiting for maintainer feedback. Which is to say that I didn't express super clearly what kind of feedback I was looking for. Let me give it another shot:

I've put together a patch that updates write_cells and ModuleMaker to do the things described in #965. If you've already got something, no worries; I'm happy to let my patch go.

If not: I'm assuming this should be a user-visible feature. If that's true, how would you prefer to see it surfaced? Something in settings.ini with a corresponding command-line switch?

@dmose
Copy link
Author

dmose commented Mar 9, 2025

@hamelsmu I would reopen the issue, but it appears that I don't have the permissions to do that...

@hamelsmu
Copy link
Contributor

hamelsmu commented Mar 9, 2025

@dmose do you mind fixing the merge conflict

@hamelsmu hamelsmu reopened this Mar 9, 2025
@jph00 jph00 deleted the branch AnswerDotAI:master April 13, 2025 22:55
@jph00 jph00 closed this Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants