Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support py310 style union annotations #636

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

seeM
Copy link
Contributor

@seeM seeM commented Jun 27, 2022

This extends nbdev.export to work with patched functions that use py310 style union annotations, and converts all instances of the tuple style to py310 style. Tuple style still is still supported.

cc @hamelsmu @jph00

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seeM seeM changed the title use py310 style union annotations support py310 style union annotations Jun 27, 2022
@seeM seeM marked this pull request as ready for review June 27, 2022 09:42
@seeM
Copy link
Contributor Author

seeM commented Jun 27, 2022

@jph00 this is now ready for review. It extends nbdev.export to work with patched functions that use py310 style union annotations, and converts all instances of the tuple style to py310 style. The old style still works though, so this isn't dependent on any other changes to fastcore.

@jph00 jph00 merged commit e36b0d2 into AnswerDotAI:master Jun 27, 2022
@jph00 jph00 added the enhancement New feature or request label Jun 27, 2022
@seeM seeM deleted the union-annots branch July 7, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants