Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Deploy Related Issues #26

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Fix: Deploy Related Issues #26

merged 2 commits into from
Apr 14, 2024

Conversation

Ant-Shell
Copy link
Owner

Pull Request

Category: [Fix]

Description:

This PR attempts to fix the following issues discovered when deploying to Vercel:

  • Background image repeating
    • Added bg-no-repeat to remediate
  • Uncaught ReferenceError: require is not defined, which seemed to be related to using the pexels client library as referenced here
    • Rewrote fetch function to migrate away from using it

Next Steps:

  • Keep troubleshooting to ensure deploy works as expected, if necessary
  • Create README page, once deploy is good

Any other comments or questions:

N/A

@Ant-Shell Ant-Shell added bug Something isn't working enhancement New feature or request labels Apr 14, 2024
@Ant-Shell Ant-Shell self-assigned this Apr 14, 2024
Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
image-match-game ✅ Ready (Inspect) Visit Preview Apr 14, 2024 6:09pm

@Ant-Shell
Copy link
Owner Author

Ant-Shell commented Apr 14, 2024

Looks ok on the preview - merging!

@Ant-Shell Ant-Shell merged commit fbb092e into main Apr 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant