feat(study): normalize study path #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 22, 2025 15:30
added 2 commits
January 29, 2025 16:43
smailio
commented
Jan 30, 2025
| @@ -66,9 +66,6 @@ def test_get(tmp_path: str, project_path) -> None: | |||
| data = {"titi": 43} | |||
| sub_route = "settings" | |||
|
|
|||
| path = path_study / "settings" | |||
| key = "titi" | |||
|
|
|||
There was a problem hiding this comment.
These variables were unused
| @@ -100,7 +97,6 @@ def test_get_cache(tmp_path: str) -> None: | |||
| path_study.mkdir() | |||
| (path_study / "settings").mkdir() | |||
| (path_study / "study.antares").touch() | |||
| path = path_study / "settings" | |||
|
|
|||
MartinBelthle
changed the title
MartinBelthle
requested changes
Jan 30, 2025
smailio
commented
Jan 30, 2025
| @@ -288,6 +289,23 @@ def __eq__(self, other: t.Any) -> bool: | |||
| def to_json_summary(self) -> t.Any: | |||
| return {"id": self.id, "name": self.name} | |||
|
|
|||
| @validates("folder") # type: ignore | |||
There was a problem hiding this comment.
sqlachemu doesn't provide a type for this decorator
| if not path: | ||
| return path | ||
| pure_path = PurePath(path) | ||
| return pure_path.as_posix() |
There was a problem hiding this comment.
Minor: all this could be simplfied in one line:
return PurePath(path).as_posix() if path else path
MartinBelthle
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The front end can't handle windows path, the desktop version on windows won't display the study hierarchy correctly.
The front end relies on the folder field of Study. This PR adds a validator to that field that normalize any path, including windows path to a posix path.