[ant-1330]+minizip #2049
Closed
[ant-1330]+minizip #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change the base branch to the "add ANTLR + YAMLCPP" branch ? This PR should then become tiny |
|
Merged
|
i'm closing this one, more sophisticated work --> #2078 |
JasonMarechal25
added a commit
that referenced
this pull request
May 30, 2024
Continuing work on VCPKG for Linux, basically trying to simplify workflows from #2049 and using manifest mode. **Status** - Build OK for all workflows - Caching OK for all workflows **Overall strategy** Merge this in feature branch `feature/vcpkg-dependencies` first. The whole feature branch will be merged only once it brings sufficient added value to existing mechanisms. In particular, when we are able to remove the use of `antares-deps` in favor of using vcpkg would be a good time to do so. Documentation should be updated in `feature/vcpkg-dependencies` when the developer workflow is clear. --------- Signed-off-by: Sylvain Leclerc <[email protected]> Co-authored-by: Florian OMNES <[email protected]> Co-authored-by: Jason Marechal <[email protected]> Co-authored-by: Jason Maréchal <[email protected]> Co-authored-by: Florian OMNES <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows #1985
adds minizip from vcpkg