Feature/vcpkg linux #2078
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,28 @@ jobs: | |
| yum install -y centos-release-scl | ||
| yum install -y devtoolset-10-gcc* | ||
|
|
||
| - name: Install cmake 3.28 | ||
| run: pip3 install cmake==3.28.4 | ||
|
|
||
| - name: Install VCPKG | ||
| # Note: we need to use environment variables instead of workflow variables | ||
| # because github messes up path variables when running in container, | ||
| # see https://github.com/actions/runner/issues/2058 | ||
| run: | | ||
| git submodule update --init vcpkg && ./vcpkg/bootstrap-vcpkg.sh -disableMetrics | ||
| echo "VCPKG_ROOT=$GITHUB_WORKSPACE/vcpkg" >> $GITHUB_ENV | ||
| echo "VCPKG_CACHE_DIR=$GITHUB_WORKSPACE/vcpkg_cache" >> $GITHUB_ENV | ||
| echo "VCPKG_BINARY_SOURCES=clear;files,$GITHUB_WORKSPACE/vcpkg_cache,readwrite" >> $GITHUB_ENV | ||
|
|
||
| - name: Restore vcpkg binary dir from cache | ||
| id: cache-vcpkg-binary | ||
| # Note: we are stuck with v3, because v4 is not compatible with oracle8 image | ||
| uses: actions/cache/restore@v3 | ||
| with: | ||
| path: ${{ env.VCPKG_CACHE_DIR }} | ||
| key: vcpkg-cache-centos7-${{ hashFiles('src/vcpkg.json', '.git/modules/vcpkg/HEAD') }} | ||
| # Allows to restore a cache when deps have only partially changed (like adding a dependency) | ||
| restore-keys: vcpkg-cache-centos7- | ||
|
There was a problem hiding this comment. wow! i would recommend to place the "install vcpkg and the restore cache" jobs in dedicated file There was a problem hiding this comment. Unfortunately it does not seem so easy, because we cannot have "post actions" in composite github actions :( I wanted to have the 3 steps "install VCPKG", "restore cache" and "save cache" in the same action, but it's not possible. So I'm afraid I will leave it this way for now ... |
||
|
|
||
| - name: Init submodule | ||
| run: | | ||
|
|
@@ -77,20 +98,21 @@ jobs: | |
| dnf -y config-manager --add-repo https://cli.github.com/packages/rpm/gh-cli.repo | ||
| dnf -y install gh | ||
|
|
||
| - name: Configure | ||
| run: | | ||
| source /opt/rh/devtoolset-10/enable | ||
| source /opt/rh/rh-git227/enable | ||
| cmake -B _build -S src \ | ||
| -DCMAKE_C_COMPILER_LAUNCHER=ccache \ | ||
| -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ | ||
| -DCMAKE_TOOLCHAIN_FILE=$GITHUB_WORKSPACE/vcpkg/scripts/buildsystems/vcpkg.cmake \ | ||
| -DDEPS_INSTALL_DIR=/rte-antares-deps-Release \ | ||
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -DBUILD_TESTING=ON \ | ||
| -DBUILD_not_system=OFF \ | ||
| -DBUILD_TOOLS=ON \ | ||
| -DBUILD_UI=OFF \ | ||
| -DCMAKE_PREFIX_PATH=${{ env.ORTOOLSDIR }}/install \ | ||
|
|
||
| - name: Build | ||
| run: | | ||
|
|
@@ -139,4 +161,10 @@ jobs: | |
| run: | | ||
| gh release upload "$tag" _build/*.tar.gz _build/*.rpm | ||
|
|
||
| - name: Cache vcpkg binary dir | ||
|
There was a problem hiding this comment. Even in the case of build errors ? There was a problem hiding this comment. Good question :
|
||
| if: always() | ||
| id: save-cache-vcpkg-binary | ||
| uses: actions/cache/save@v3 | ||
| with: | ||
| path: ${{ env.VCPKG_CACHE_DIR }} | ||
| key: vcpkg-cache-centos7-${{ hashFiles('src/vcpkg.json', '.git/modules/vcpkg/HEAD') }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,8 @@ jobs: | |
| env: | ||
| ORTOOLS_DIR: ${{ github.workspace }}/or-tools | ||
| os: ubuntu-20.04 | ||
| # Caching strategy of VCPKG dependencies | ||
| VCPKG_BINARY_SOURCES: "clear;files,${{ github.workspace }}/vcpkg_cache,readwrite" | ||
|
|
||
| runs-on: ubuntu-20.04 | ||
| if: "!contains(github.event.head_commit.message, '[skip ci]')" | ||
|
|
@@ -45,17 +47,29 @@ jobs: | |
| with: | ||
| ref: ${{ env.REF }} | ||
|
|
||
| - name: Install VCPKG | ||
| run: git submodule update --init vcpkg && ./vcpkg/bootstrap-vcpkg.sh -disableMetrics | ||
|
|
||
| - name: Restore vcpkg binary dir from cache | ||
| id: cache-vcpkg-binary | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: ${{ github.workspace }}/vcpkg_cache | ||
| key: vcpkg-cache-ubuntu-${{ hashFiles('src/vcpkg.json', '.git/modules/vcpkg/HEAD') }} | ||
| # Allows to restore a cache when deps have only partially changed (like adding a dependency) | ||
| restore-keys: vcpkg-cache-ubuntu- | ||
|
|
||
| - name: ccache | ||
| uses: hendrikmuhs/[email protected] | ||
| with: | ||
| key: ${{ env.os }} | ||
|
|
||
| - name: Install libraries | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install uuid-dev libwxgtk3.0-gtk3-dev | ||
| sudo apt-get install libboost-test-dev | ||
| sudo apt-get install g++-10 gcc-10 | ||
|
|
||
| - name: Read antares-deps version | ||
| id: antares-deps-version | ||
|
|
@@ -95,24 +109,24 @@ jobs: | |
|
|
||
| - name: Configure | ||
| run: | | ||
| cmake -B _build -S src \ | ||
| -DCMAKE_C_COMPILER_LAUNCHER=ccache \ | ||
| -DCMAKE_C_COMPILER=/usr/bin/gcc-10 \ | ||
| -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ | ||
| -DCMAKE_CXX_COMPILER=/usr/bin/g++-10 \ | ||
| -DCMAKE_TOOLCHAIN_FILE=${{ github.workspace }}/vcpkg/scripts/buildsystems/vcpkg.cmake \ | ||
| -DDEPS_INSTALL_DIR=${{github.workspace}}/rte-antares-deps-Release \ | ||
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -DBUILD_TESTING=ON \ | ||
| -DBUILD_not_system=OFF \ | ||
| -DBUILD_TOOLS=ON \ | ||
| -DCMAKE_PREFIX_PATH=${{ env.ORTOOLS_DIR }}/install \ | ||
| -DPython3_EXECUTABLE="${{ env.Python3_ROOT_DIR }}/bin/python" | ||
|
|
||
| - name: Build | ||
| run: | | ||
| cmake --build _build -j$(nproc) | ||
|
|
||
| # simtest | ||
| - name: Read simtest version | ||
| id: simtest-version | ||
|
|
@@ -296,3 +310,11 @@ jobs: | |
| tag: ${{ github.event.inputs.release_tag }} | ||
| run: | | ||
| gh release upload "$tag" _build/*.tar.gz _build/*.deb | ||
|
|
||
| - name: Cache vcpkg binary dir | ||
| if: always() | ||
| id: save-cache-vcpkg-binary | ||
| uses: actions/cache/save@v4 | ||
| with: | ||
| path: ${{ github.workspace }}/vcpkg_cache | ||
| key: vcpkg-cache-ubuntu-${{ hashFiles('src/vcpkg.json', '.git/modules/vcpkg/HEAD') }} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a v2 maybe use https://github.com/lukka/run-vcpkg