Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all hydro checks outside simulation's loop #2159

Merged
merged 11 commits into from
Jun 13, 2024
Merged

Run all hydro checks outside simulation's loop #2159

merged 11 commits into from
Jun 13, 2024

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Jun 13, 2024

@flomnes what do you think?

@a-zakir a-zakir requested a review from flomnes June 13, 2024 09:37
@flomnes flomnes changed the title run all hydro checks outside simulation's loop Run all hydro checks outside simulation's loop Jun 13, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 13, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@flomnes flomnes merged commit 2b4d4d0 into feature/pre-check-hydraulic-inputs Jun 13, 2024
1 check passed
@flomnes flomnes deleted the feature/run-all-checks-before-set-of-parrallels-years branch June 13, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-zakir @flomnes