Remove duplication in simulation run #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilpier-code
commented
Jul 19, 2024
| @@ -95,6 +96,9 @@ class Application final: public Yuni::IEventObserver<Application, Yuni::Policy:: | |||
| void runSimulationInAdequacyMode(); | |||
There was a problem hiding this comment.
These methods are about to be removed
void runSimulationInAdequacyMode();
void runSimulationInEconomicMode();
| @@ -104,8 +105,6 @@ SimulationResults APIInternal::execute() const | |||
| // Importing Time-Series if asked | |||
| study_->importTimeseriesIntoInput(); | |||
There was a problem hiding this comment.
study_->importTimeseriesIntoInput();Do we need this in API ?
|
flomnes
approved these changes
Jul 31, 2024
guilpier-code
force-pushed
the
fix/remove-duplication-simulation-run
branch
from
063ae29 to
1694e4c
Compare
…lClusters automatically when running a simulation
flomnes
reviewed
Aug 23, 2024
src/solver/simulation/include/antares/solver/simulation/simulation-runner.h
Outdated
Show resolved
Hide resolved
| @@ -104,8 +105,6 @@ SimulationResults APIInternal::execute() const | |||
| // Importing Time-Series if asked | |||
| study_->importTimeseriesIntoInput(); | |||
Comment on lines
24
to
25
| #include "antares/solver/simulation/adequacy.h" | ||
| #include "antares/solver/simulation/economy.h" |
There was a problem hiding this comment.
These headers are not required here, please move them to simulation-runner.cpp
There was a problem hiding this comment.
ok, they will have to be moved to simulation-runner.cpp, where they are needed.
JasonMarechal25
previously requested changes
Aug 23, 2024
|
flomnes
approved these changes
Aug 23, 2024
flomnes
dismissed
JasonMarechal25’s stale review
All comments were taken into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work just started...
Situation :
There are code duplications :
Problem :
Difficult to remove the first duplication without removing the second one.
Purpose :
Remove them both.