Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple quadratic solvers #2574

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Conversation

pet-mit
Copy link
Contributor

@pet-mit pet-mit commented Jan 13, 2025

No description provided.

Signed-off-by: Peter Mitri <[email protected]>
@pet-mit pet-mit added the breaking change This PR/issue introduces a breaking change for users label Jan 13, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

{
if (options.quadraticSolver != "sirius")
{
const std::string notFound = "Solver " + options.quadraticSolver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t understand this condition

@@ -35,23 +35,43 @@

using namespace operations_research;

enum SolverClass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use enum class

Signed-off-by: Peter Mitri <[email protected]>
Signed-off-by: Peter Mitri <[email protected]>
Signed-off-by: Peter Mitri <[email protected]>
Signed-off-by: Peter Mitri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This PR/issue introduces a breaking change for users size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants