Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze the code and optimize the code #10515

Closed
wants to merge 9 commits into from

Conversation

6-BennyLi-9
Copy link
Contributor

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

Analyze the code and optimize the code. The changes of gradle files in history should be ignored.

@6-BennyLi-9
Copy link
Contributor Author

I don't understand why it runs successfully in local.

@JasonP01
Copy link
Contributor

Task :core:kaptKotlin FAILED
/home/runner/work/Mindustry/Mindustry/core/src/mindustry/logic/LCanvas.java:687: error: illegal start of expression
public void prepareHeight(){
^

The failure @6-BennyLi-9

@6-BennyLi-9
Copy link
Contributor Author

done debug, see in new pr

@JasonP01
Copy link
Contributor

Stop making new prs

@JasonP01
Copy link
Contributor

Its still failing, this pr is uselsss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants