Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Launch Music for Each Planet #8901

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Custom Launch Music for Each Planet #8901

merged 7 commits into from
Nov 30, 2023

Conversation

Mythril382
Copy link
Contributor

@Mythril382 Mythril382 commented Aug 7, 2023

To-do:

  • Add (h)json support.

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@Anuken
Copy link
Owner

Anuken commented Aug 12, 2023

I don't think the three music categories are good enough of a system to warrant being configurable per-planet.

@Mythril382 Mythril382 marked this pull request as ready for review August 12, 2023 01:17
@Anuken Anuken merged commit 5fe2825 into Anuken:master Nov 30, 2023
1 check passed
@MEEPofFaith
Copy link
Contributor

Custom ambient/dark/boss music for each planet when

@Anuken
Copy link
Owner

Anuken commented Nov 30, 2023

The definitions of dark/boss are pretty vague right now, so I think planets should define that themselves. Maybe a custom handler of some sort?

@Mythril382 Mythril382 deleted the lunch branch July 2, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants