Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hungarian translation #9675

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Conversation

meskobalazs
Copy link
Contributor

Only affects bundle_hu.properties. @summoner001: feel free to check if everything is in order before merging.

@broganeuquoixe
Copy link

I don't know Hungarian however please don't format the triple dots (...) with () because that breaks the text rendering of the tech font. Always test your bundles before sending a PR.

Please look at the loading... text in the following videos

Here it's using ...

triple_dot_normal.mp4

Here it's with

triple_dot_single_char.mp4

Changed triple dots to three dots
@meskobalazs
Copy link
Contributor Author

@broganeuquoixe Thanks, I've fixed this.

@summoner001
Copy link
Contributor

Only affects bundle_hu.properties. @summoner001: feel free to check if everything is in order before merging.

Hi! Thank you for your help!
I started to review it. It will take a few days.

@summoner001
Copy link
Contributor

summoner001 commented Mar 27, 2024

  1. Line 234: false letter: ħ
  2. Please check commas before "vagy" and "hogy" words.
  3. Please check ]t misspells
  4. If you translate the word cyanogen into its Hungarian equivalent (Dician), please translate all occurrences of the word in the whole text
  5. If you change an already translated word Belső-égetésű erőmű -> Égetőerőmű, please rewrite all its occurrences in the whole text
  6. If you change an already translated word Rotary pump which is translated by professionals as Fogaskerék szivattyú please do not use Forgó szivattyú. Please rewrite all its occurrences in the whole text.

In the first glance, these would be the most important errors.

+1: Please do not follow the english language file in this case and don't use /u26A0 instead of ⚠ but I've already said that, I'll just write it here.

I will keep checking and write if I find any more errors and bugs.

Nice work. Thank you!

@summoner001
Copy link
Contributor

If you change an already translated word Világprocesszor (Világ processzor) -> Világfeldolgozó, please rewrite all its occurrences in the whole text

Have you renamed many buildings? Please rewrite them all so that they always translate to the same word.

Line: 2046 - misspelled word: termelőegysésgek
Line: 2454 - non-matching brackets: [ )

@meskobalazs
Copy link
Contributor Author

meskobalazs commented Mar 28, 2024

I have gone through your feedback, some were trivial to fix, so I won't comment on those, as for the others:

  • vagy and hogy: fixed a couple of cases of vagy, hogy was correct everywhere as far as I can see
  • Rotary pump: I went with fogaskeres szivattyú, that sound more natural to me, and it is also used "in the wild"
  • Világprocesszor: actually I went with processzor, I just forgot to change this one back. So it is the same again.
  • non-matching brackets: [ ): This is not a mistake, this means that the interval is open at the right side (and closed at the left), so the generated value will in the range of 0 to N-1, and it will never be N (it is the exact same in the English string).

@meskobalazs
Copy link
Contributor Author

Now the PR is ready to be merged.

@summoner001
Copy link
Contributor

@Anuken :

Ready to merge

@Anuken Anuken merged commit 5d180e9 into Anuken:master Mar 29, 2024
1 check passed
@summoner001
Copy link
Contributor

Thank you for the fast merge.
Happy Easter!
Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants