fix: add timeout to asyncio subscription send wait #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility of fetching wrong response
fubuloubu
approved these changes
Jan 8, 2025
| @@ -17,6 +17,7 @@ class Web3SubscriptionsManager: | |||
| websocket_reconnect_max_tries: int = 3 | |||
| rpc_response_timeout_count: int = 10 | |||
| subscription_polling_time: float = 0.1 # secs | |||
| request_timeout: float = 50.0 | |||
There was a problem hiding this comment.
It's what web3.py uses as a default request timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and removes possibility of fetching wrong response
What I did
updated asyncio patterns for web3 7
fixes: #
How I did it
How to verify it
Checklist