Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade esbuild from 0.19.2 to 0.19.3 #7

Closed

Conversation

corrideat
Copy link
Member

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to upgrade esbuild from 0.19.2 to 0.19.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.
  • The recommended version was released 22 days ago, on 2023-09-14.
Release notes
Package name: esbuild
  • 0.19.3 - 2023-09-14
    • Fix list-style-type with the local-css loader (#3325)

      The local-css loader incorrectly treated all identifiers provided to list-style-type as a custom local identifier. That included identifiers such as none which have special meaning in CSS, and which should not be treated as custom local identifiers. This release fixes this bug:

      / Original code */
      ul { list-style-type: none }

      /* Old output (with --loader=local-css) */
      ul {
      list-style-type: stdin_none;
      }

      /* New output (with --loader=local-css) */
      ul {
      list-style-type: none;
      }

      Note that this bug only affected code using the local-css loader. It did not affect code using the css loader.

    • Avoid inserting temporary variables before use strict (#3322)

      This release fixes a bug where esbuild could incorrectly insert automatically-generated temporary variables before use strict directives:

      // Original code
      function foo() {
      'use strict'
      a.b?.c()
      }

      // Old output (with --target=es6)
      function foo() {
      var _a;
      "use strict";
      (_a = a.b) == null ? void 0 : _a.c();
      }

      // New output (with --target=es6)
      function foo() {
      "use strict";
      var _a;
      (_a = a.b) == null ? void 0 : _a.c();
      }

    • Adjust TypeScript enum output to better approximate tsc (#3329)

      TypeScript enum values can be either number literals or string literals. Numbers create a bidirectional mapping between the name and the value but strings only create a unidirectional mapping from the name to the value. When the enum value is neither a number literal nor a string literal, TypeScript and esbuild both default to treating it as a number:

      // Original TypeScript code
      declare const foo: any
      enum Foo {
      NUMBER = 1,
      STRING = 'a',
      OTHER = foo,
      }

      // Compiled JavaScript code (from "tsc")
      var Foo;
      (function (Foo) {
      Foo[Foo["NUMBER"] = 1] = "NUMBER";
      Foo["STRING"] = "a";
      Foo[Foo["OTHER"] = foo] = "OTHER";
      })(Foo || (Foo = {}));

      However, TypeScript does constant folding slightly differently than esbuild. For example, it may consider template literals to be string literals in some cases:

      // Original TypeScript code
      declare const foo = 'foo'
      enum Foo {
      PRESENT = <span class="pl-s1"><span class="pl-kos">${</span><span class="pl-s1">foo</span><span class="pl-kos">}</span></span>,
      MISSING = <span class="pl-s1"><span class="pl-kos">${</span><span class="pl-s1">bar</span><span class="pl-kos">}</span></span>,
      }

      // Compiled JavaScript code (from "tsc")
      var Foo;
      (function (Foo) {
      Foo["PRESENT"] = "foo";
      Foo[Foo["MISSING"] = <span class="pl-s1"><span class="pl-kos">${</span><span class="pl-s1">bar</span><span class="pl-kos">}</span></span>] = "MISSING";
      })(Foo || (Foo = {}));

      The template literal initializer for PRESENT is treated as a string while the template literal initializer for MISSING is treated as a number. Previously esbuild treated both of these cases as a number but starting with this release, esbuild will now treat both of these cases as a string. This doesn't exactly match the behavior of tsc but in the case where the behavior diverges tsc reports a compile error, so this seems like acceptible behavior for esbuild. Note that handling these cases completely correctly would require esbuild to parse type declarations (see the declare keyword), which esbuild deliberately doesn't do.

    • Ignore case in CSS in more places (#3316)

      This release makes esbuild's CSS support more case-agnostic, which better matches how browsers work. For example:

      / Original code */
      @ KeyFrames Foo { From { OpaCity: 0 } To { OpaCity: 1 } }
      body { CoLoR: YeLLoW }

      /* Old output (with --minify) */
      @ KeyFrames Foo{From {OpaCity: 0} To {OpaCity: 1}}body{CoLoR:YeLLoW}

      /* New output (with --minify) */
      @ KeyFrames Foo{0%{OpaCity:0}To{OpaCity:1}}body{CoLoR:#ff0}

      Please never actually write code like this.

    • Improve the error message for null entries in exports (#3377)

      Package authors can disable package export paths with the exports map in package.json. With this release, esbuild now has a clearer error message that points to the null token in package.json itself instead of to the surrounding context. Here is an example of the new error message:

      ✘ [ERROR] Could not resolve "msw/browser"

      lib/msw-config.ts:2:28:
        2 │ import { setupWorker } from 'msw/browser';
          ╵                             ~~~~~~~~~~~~~
      

      The path "./browser" cannot be imported from package "msw" because it was explicitly disabled by
      the package author here:

      node_modules/msw/package.json:17:14:
        17 │       "node": null,
           ╵               ~~~~
      

      You can mark the path "msw/browser" as external to exclude it from the bundle, which will remove
      this error and leave the unresolved path in the bundle.

    • Parse and print the with keyword in import statements

      JavaScript was going to have a feature called "import assertions" that adds an assert keyword to import statements. It looked like this:

      import stuff from './stuff.json' assert { type: 'json' }

      The feature provided a way to assert that the imported file is of a certain type (but was not allowed to affect how the import is interpreted, even though that's how everyone expected it to behave). The feature was fully specified and then actually implemented and shipped in Chrome before the people behind the feature realized that they should allow it to affect how the import is interpreted after all. So import assertions are no longer going to be added to the language.

      Instead, the current proposal is to add a feature called "import attributes" instead that adds a with keyword to import statements. It looks like this:

      import stuff from './stuff.json' with { type: 'json' }

      This feature provides a way to affect how the import is interpreted. With this release, esbuild now has preliminary support for parsing and printing this new with keyword. The with keyword is not yet interpreted by esbuild, however, so bundling code with it will generate a build error. All this release does is allow you to use esbuild to process code containing it (such as removing types from TypeScript code). Note that this syntax is not yet a part of JavaScript and may be removed or altered in the future if the specification changes (which it already has once, as described above). If that happens, esbuild reserves the right to remove or alter its support for this syntax too.

  • 0.19.2 - 2023-08-14
    Read more
from esbuild GitHub release notes
Commit messages
Package name: esbuild
  • 673ad10 publish 0.19.3 to npm
  • 6402f11 basic support for parsing import attributes
  • 7ece556 fix #3322: avoid temporaries before `"use strict"`
  • 900a90d transform: banner/footer with local-css/global-css
  • bbd82b2 run `make update-compat-table`
  • f702f6b remove an unused method
  • a111cc4 fix #3318: ignore invalid commands for old builds
  • 4c5db58 fix #3329: treat more enum values as strings
  • 5ecf535 fix #3377: improve resolution error due to `null`
  • 79ac17a resolver: adjust some error messages
  • e48baa3 fix #3316: make the css parser more case-agnostic
  • 8d52aaf fix #3351: move initial watch mode log to later on
  • 56e25c1 fix #3325: `list-style-type` and reserved idents
  • cc74cd0 Update new-issue.md
  • e330bde another sanity check for #3311

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: [email protected]

@corrideat corrideat closed this Feb 23, 2024
@corrideat corrideat deleted the snyk-upgrade-d5677ef9190a62dd637d2002d299c466 branch May 12, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants