Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retries for subprocess commands #22

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

michael-sbarra-apexai
Copy link
Contributor

@michael-sbarra-apexai michael-sbarra-apexai commented Oct 7, 2024

#21

@michael-sbarra-apexai michael-sbarra-apexai force-pushed the 21-allow-retries-subprocess branch from 0ca99d3 to a5cf697 Compare October 7, 2024 22:17
@michael-sbarra-apexai michael-sbarra-apexai merged commit 38d3c91 into main Oct 7, 2024
2 checks passed
@michael-sbarra-apexai michael-sbarra-apexai deleted the 21-allow-retries-subprocess branch October 7, 2024 23:59
@kilian-funk
Copy link
Collaborator

@michael-sbarra-apexai What is the purpose of this change? If the timeout is too short, can you not simply increase the timeout instead of adding all of this complexity to the code?

@michael-sbarra-apexai
Copy link
Contributor Author

@michael-sbarra-apexai What is the purpose of this change? If the timeout is too short, can you not simply increase the timeout instead of adding all of this complexity to the code?

@kilian-funk See #21. If some brief network interruption occurred, the whole file builder would be lost resulting in the error shown in the issue. I also found sometimes the git ... command would hang and not terminate, which is why I added the timeout. This now adds a max_retries = 3 with a timeout of 20s (for git clone), so the file build will not fail on some brief network issue. In additional testing, I found that timeout of 5s should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants