Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix RN 78 compatibility (unit() was removed) #568

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix RN 78 compatibility (unit() was removed) #568

wants to merge 1 commit into from
+2 −2

Conversation

mrousavy
Copy link
Contributor

Summary

Test Plan

@jacobp100
Copy link
Collaborator

Is this backwards compatible?

@mrousavy
Copy link
Contributor Author

Good question. Probably not, might require a #if RN version check.

@janicduplessis
Copy link
Collaborator

Yea, I think we will have to start to commit to some backward compat for new arch since it is now enabled by default.

I think ifdef would be good, but might need to change build files to pass the RN version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrousavy @jacobp100 @janicduplessis