Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dhewm3 #3318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create Dhewm3 #3318

wants to merge 1 commit into from

Conversation

tx00100xt
Copy link
Contributor

@probonopd
Copy link
Member

Thanks @tx00100xt. Unfortunately the screenshot shows only a black screen.
Does this application work when there is no internet connection?

@tx00100xt
Copy link
Contributor Author

No internet connection needed. AppImage works without it.
Instead of a black window there should be a window like this:
Снимок экрана в 2024-03-26 02-17-29

I added a patch that creates a SDL2 window if there is no game data. If there is game data, the game starts.
https://github.com/tx00100xt/dhewm3-appimage/blob/main/patches/0001-dhewm3-AppImage.patch
On the live DVD(ubuntu-18.04.6-desktop-amd64.iso )the window is displayed correctly:

appimage_livedvd_test.webm
appimage_without_internet_test.webm

Screenshots are also in the metainfo files.
https://github.com/tx00100xt/dhewm3-appimage/blob/main/AppDir/usr/share/metainfo/org.dhewm3.Dhewm3.appdata.xml
Github Аction recognized them:
https://github.com/AppImage/appimage.github.io/actions/runs/8030743687/job/21938371983?pr=3318#step:5:917

@probonopd
Copy link
Member

Our test on the headless server just shows:

image

Since this is a game, maybe it needs some fancy GPU?

@tx00100xt
Copy link
Contributor Author

Hello.

Since this is a game, maybe it needs some fancy GPU?

No. A regular VirtualBox adapter is enough.
I assume that your system may not always take the right screenshots.
On any real hardware, VirtualBox or VMware will have the image shown above.

@probonopd
Copy link
Member

Thanks for letting me know. It is very well possible that this is an issue with the test itself, but at the moment I don't know how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants